I actually like the newer methods, as it increases the chances of me actually getting something of interest. After all, the only shiny that is a virtual guarantee for me is Zubat. Seriously, I've caught at least one shiny Zubat in at least one game in every generation since introduction. I have enough to fill half a bank box at this point. And, besides, unlike most, 85% of the time I don't actively hunt for shinies, so whenever I actually get one, it still feels special. I only try to hunt them down when the method is easy and/or it's one I want, but even then I just prefer to let it happen on its own. They only feel cheap when they're outright handed to you, usually via events, especially if they're not legends (which tend to be shiny locked in certain cases). To be honest, however, Gen VII's methods are much more frustrating than Gens V and VI, especially since it reworks things like Masuda Method (and the less said about SOS battles, the better), which makes finding shinies even harder, even IF you have all the elements needed in play.
So, I have to disagree, as the newer methods are fine (except Gen VII), and there is still a chance factor in play. Things like the Shiny Charm and Masuda Method just make things a tad easier to manipulate it into your favor. But, regardless, there is still a chance factor involved, so it's still a rarity overall. So, I'm fine with most of the newer methods, as the original chances were just plain dismal and unfair.